Skip to content

[AMAZON CAPI] - draft amazon capi destination #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joe-ayoub-segment
Copy link
Contributor

Code taken from this PR by Amazon Partner. Code review was too complex so I started a refactor in another branch that I could push to.

Testing

WIP

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Amazon Conversions Api, Settings:region,advertiserId
  • Destination: Amazon Conversions Api, Action:trackConversion, Fields:name,eventType,eventActionSource,countryCode,timestamp,matchKeys,enable_batching

Add these new fields as optional instead and assume default values in perform or performBatch block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant