Skip to content

[Linkedin Audiences] Update linkedin API version to 202505 #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented May 27, 2025

Upgrade linkedin API version to 202505 since current version is getting deprecated soon.

JIRA -> https://twilio-engineering.atlassian.net/browse/STRATCONN-5805?atlOrigin=eyJpIjoiNDE3YTVjNzQ0ZjY4NDY5Y2JlMWUxMDAxZDdiNjRjZTYiLCJwIjoiaiJ9

Testing

Testing document.

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (0451a3d) to head (44214a3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2945   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files        1064     1064           
  Lines       19612    19612           
  Branches     3767     3767           
=======================================
  Hits        15313    15313           
  Misses       3015     3015           
  Partials     1284     1284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review May 28, 2025 09:28
@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner May 28, 2025 09:28
@harsh-joshi99 harsh-joshi99 requested a review from Copilot May 28, 2025 09:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the LinkedIn API version to 202505 ahead of deprecation and regenerates associated snapshots.

  • Bump LINKEDIN_API_VERSION constant from 202409 to 202505
  • Regenerate snapshots in updateAudience and root linkedin-audiences tests to reflect new version header

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
constants.ts Updated LINKEDIN_API_VERSION to 202505
updateAudience/tests/snapshots/snapshot.test.ts.snap Updated snapshot header value to 202505
tests/snapshots/snapshot.test.ts.snap Updated snapshot header value to 202505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants