Fix: cannot remove objects by setting to null #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how this hasn't affected us before, but today we found that we were unable to remove an object with schema field from an item by setting it to null (as works with scalar fields). Instead it throws an error.
I found two places that caused an issue:
collectNested: tries to collect the properties of the object but throws an error as it's null so has no propertiesconvertNulls: skips the field if it has a schema, so never removes itI've made this PR to resolve the issue. On my testing it seems to work fine, the unit tests also all pass.
However I'm not sure if this change might have some hidden impact I'm not aware of.