Zoom Pulse Mode #40
Zoom Pulse Mode #40
Conversation
|
I should mention that I couldn't find a good place to clear the |
|
This has the risk of the zooming looking choppy even if the underlying rendering isn't, because of the timer being de-synchronized from the frames. Probably better to use |
demo/client/src/view.ts
Outdated
| } | ||
| let c = 0; | ||
| let d = 0.005; | ||
| this.pulseTimer = window.setInterval(() => { |
There was a problem hiding this comment.
Please use requestAnimationFrame()
| @@ -306,6 +311,10 @@ export class PerspectiveCamera extends Camera { | |||
| ]); | |||
| } | |||
|
|
|||
| zoom(scale: number): void { | |||
There was a problem hiding this comment.
I wanted to keep the old zoom function private, but I needed something public that only took the scale argument. So I renamed the private function to _zoom and exposed the new function as zoom.
|
@trishume good idea, I switched to RAFs in the latest patch. |
|
Works for me. |
Depends on #38
This PR adds a Zoom Pulse button to slowly zoom in and out the Text and SVG demo. The goal is to demonstrate how smooth rendering is.