This repository was archived by the owner on May 28, 2024. It is now read-only.
Use bitflags 0.5 #77
Merged
Use bitflags 0.5 #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if the lockfiles need to be updated as well, otherwise r=me. |
|
Note that all bitflags are private by default in 0.5. |
|
@KiChjang @saurvs this change as-is will likely break Servo, per what @Ms2ger says. Please use http://doc.crates.io/guide.html#overriding-dependencies to build it against your branch of rust-selectors. You should see a build error about I keep in my |
|
@KiChjang The crate builds now. |
|
@bors-servo r+ |
|
📌 Commit 9a7c685 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 2, 2016
Use bitflags 0.5 Part of servo/servo#10077 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/77) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of servo/servo#10077
This change is