Skip to content
This repository was archived by the owner on May 28, 2024. It is now read-only.

Use bitflags 0.5 #77

Merged
merged 1 commit into from
Apr 2, 2016
Merged

Use bitflags 0.5 #77

merged 1 commit into from
Apr 2, 2016

Conversation

saurvs
Copy link

@saurvs saurvs commented Mar 23, 2016

Part of servo/servo#10077


This change is Reviewable

@KiChjang
Copy link

Not sure if the lockfiles need to be updated as well, otherwise r=me.

@KiChjang KiChjang self-assigned this Mar 23, 2016
@Ms2ger
Copy link

Ms2ger commented Mar 23, 2016

Note that all bitflags are private by default in 0.5.

@SimonSapin
Copy link
Member

@KiChjang Cargo.lock is in .gitignore for this repository.

@saurvs this change as-is will likely break Servo, per what @Ms2ger says. Please use http://doc.crates.io/guide.html#overriding-dependencies to build it against your branch of rust-selectors. You should see a build error about ElementFlags being private, and you’ll be able to test a fix and update this PR.

I keep in my .cargo/config file a bunch of path overrides commented-out, one per line, so I can uncomment them as needed.

@saurvs
Copy link
Author

saurvs commented Apr 2, 2016

@KiChjang The crate builds now.

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link

📌 Commit 9a7c685 has been approved by SimonSapin

@bors-servo
Copy link

⌛ Testing commit 9a7c685 with merge ec406f1...

bors-servo pushed a commit that referenced this pull request Apr 2, 2016
Use bitflags 0.5

Part of servo/servo#10077

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/77)
<!-- Reviewable:end -->
@bors-servo
Copy link

☀️ Test successful - travis

@bors-servo bors-servo merged commit 9a7c685 into servo:master Apr 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants