Skip to content

Use bitflags 0.5 in the breaks branch #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use bitflags 0.5 in the breaks branch #367

wants to merge 1 commit into from

Conversation

saurvs
Copy link

@saurvs saurvs commented Mar 26, 2016

@saurvs saurvs changed the title Use bitflags 0.5 Use bitflags 0.5 in the breaks branch Mar 26, 2016
@saurvs saurvs changed the title Use bitflags 0.5 in the breaks branch Use bitflags 0.5 in the breaks branch Mar 26, 2016
@sfackler
Copy link
Owner

Doesn't appear to compile: https://travis-ci.org/sfackler/rust-openssl/builds/118684997

@gkoz
Copy link
Contributor

gkoz commented Mar 26, 2016

Bitflags 0.5 makes everything private by default. You can't just bump the version, you need to change flags Foo: ... to pub flags Foo: ....

@saurvs
Copy link
Author

saurvs commented Apr 6, 2016

I added pub but it doesn't fix it because it the ffi_extras and ffi namespaces aren't being resolved for some reason. It works fine if the constants from those modules are replaced with literals. Any idea why this is happening?

@sfackler
Copy link
Owner

Covered by #385

@sfackler sfackler closed this Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants