Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ShareDB backend commits an op/snapshot pair, the version of the snapshot is always 1 higher than the version of the op.
When checking for the maximum current snapshot version, we should therefore query the
snapshots
table directly, not theops
table.When committing ops, we should therefore also use
op.v
, notsnapshot.v
. If we usesnapshot.v
, theversion
field in theops
table will contain a different number from the JSON representation of the op in theoperation
field. (This is precisely what happens with the current version of the library.)When getting a range of operations with
.getOps()
, I found that rows were sometimes being returned out of order; adding an explicitORDER BY
clause to the query fixes the issue.