e2e tests, CF, agent and guest #1173
Conversation
|
giavac
changed the title
|
I remember one more thing; since this is a CF e2e test, do you mind adding this to the Playwright "callfabric" project here? Currently, it is probably in the "default" project. |
| @@ -134,11 +134,13 @@ test.describe(agent_customer_static_scripts_desc, () => { | |||
|
|
|||
| const agent_customer_external_url_desc = 'CallFabric Agent/Customer interaction, cXML with external URL' | |||
| test.describe(agent_customer_external_url_desc, () => { | |||
| const external_url_for_cxml = process.env.EXTERNAL_URL_FOR_CXML || 'https://us-central1-video-load-testing-with-gcf.cloudfunctions.net/gcf-external-url' | |||
There was a problem hiding this comment.
could this one var be loaded from a GHA secret, separate from the current block? Then we just need to add one secret, not update all of them or hardcode this.
There was a problem hiding this comment.
yes, that would be fine for me. If we add EXTERNAL_URL_FOR_CXML as a variable, I guess it will be accessible in the same way, with process.env. EXTERNAL_URL_FOR_CXML?
There was a problem hiding this comment.
the env needs to be hydrated of sorts by the secret, I think like #1188
There was a problem hiding this comment.
ok, I've cherry-picked that change.
Description
Adds e2e tests for Call Fabric scenarios like Agent and Customer (guest token) joining the same cXML conference.
It requires two new ENV vars:
EXTERNAL_URL_FOR_CXML, pointing to the external URL to be used in the second scenario.CXML_STREAM_URL, pointing to the desired stream URL.Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.