Skip to content

CI: Downgrade the Ubuntu version for the E2E Tests #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 18, 2025
Merged

CI: Downgrade the Ubuntu version for the E2E Tests #1175

merged 9 commits into from
Feb 18, 2025

Conversation

iAmmar7
Copy link
Member

@iAmmar7 iAmmar7 commented Feb 14, 2025 •
edited
Loading

Description

Downgrade ubuntu-latest to ubuntu-22.04 due to the known issue as mentioned here: microsoft/playwright#30368

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f2e9fc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iAmmar7 iAmmar7 force-pushed the aa/fix-playwright-ubuntu branch from 276fc6f to 51ebe45 Compare February 17, 2025 11:46
iAmmar7
iAmmar7 commented Feb 17, 2025
View reviewed changes
.github/workflows/browser-js-production.yml
@@ -13,7 +13,7 @@ concurrency:
jobs:
e2e-tests:
name: Run E2E tests
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned here: microsoft/playwright#30368, to fix the issue, we can either upgrade Playwright to 1.48.0 or downgrade Ubuntu. I tried upgrading the Playwright, but it did not work out.

@ryanwi let me know if it is okay to use this Ubuntu version for the e2e tests.

@iAmmar7 iAmmar7 changed the title WIP: Update playwright in the Realtime API CI CI: Downgrade the Ubuntu version for the E2E Tests Feb 17, 2025
jpsantosbh
jpsantosbh reviewed Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@jpsantosbh jpsantosbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @ryanwi

@ryanwi
Copy link
Contributor

ryanwi commented Feb 17, 2025

ok, but can follow-up be done to get the playwright upgrade working?

@jpsantosbh jpsantosbh merged commit 1624aa7 into main Feb 18, 2025
23 of 25 checks passed
@jpsantosbh jpsantosbh deleted the aa/fix-playwright-ubuntu branch February 18, 2025 12:30
@iAmmar7
Copy link
Member Author

iAmmar7 commented Feb 25, 2025

ok, but can follow-up be done to get the playwright upgrade working?

I created a PR to upgrade that last year #1154, and it is still open. 😄 🤷‍♂️

iAmmar7 added a commit that referenced this pull request Apr 30, 2025
@iAmmar7
CI: Downgrade the Ubuntu version for the E2E Tests (#1175)
1a0ba32 
* setup package for e2e-js

* use ubuntu-latest

* avoid cache

* no cache with ubuntu latest

* use v1.48.2

* use ubuntu-22

* remove lock changes:

* use latest node and ubuntu-22.04 for e2e tests

* update 22 to 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsantosbh jpsantosbh jpsantosbh left review comments

@ryanwi ryanwi ryanwi approved these changes

@giavac giavac Awaiting requested review from giavac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iAmmar7 @ryanwi @jpsantosbh