-
Notifications
You must be signed in to change notification settings - Fork 2
FEATURE: allow to pass paths from outside without searching in them #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amtoine
wants to merge
5
commits into
silicakes:main
Choose a base branch
from
amtoine:feature/compute-paths-outside-of-sessionizer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f6ec109
rename `project` into `directory`
amtoine 0f33e6c
take the paths from the outside as parameters exclusively
amtoine e115119
update the documentation of `zellij-sessionizer.nu`
amtoine 86e3ec7
add a `--depth (-d)` option
amtoine ad65065
update the README instructions and tips
amtoine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sorry for my absence!
isn't it the same as:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey 👋
no worries 😉
yeah it looks about the same 👍
i'm just using pure Nushell commands but they are looking for depth-1 directories in all the directories in the list to the left 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right!
So I'd probably add it as part of the alias (we can update the readme for it) instead of pushing it into the code as it feels like something some users would like where others would defer to an external app (such as
fd
)WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i see what you mean here by "add it as part of the alias instead of pushing it into the code" 😕
and you're talking about the Bash implementation, right?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that I think it should be part of the users config - like a parameter passed to their
.rc
aliases forzellij-sessionizer
I'm talking about both implementations as I try to maintain a single-responsibility philosophy as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i see, does that mean that you'd like the script not mentioning
find
orfd
directly?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
give it some sane defaults and let the user decide about everything that's under the title of 'customization'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh yeah, i see what you mean now 😌
i'd say, as
find
andfd
were already there before this PR, we can leave this as-is for now and tackle the removal of these commands and making them configurable in another PR? 😋Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the solution I was thinking about is sort of a flat way of passing params into your find cmd, without explicitly mentioning it within the code.
Assuming you're using
fd
- I envision something likeThen the script will just pass it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm we can't do that really in Nushell right now 😕