Add e2e tests #3137
Draft
Add e2e tests #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
c44abb7 to
c6ce63d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| // TODO add this to the test | ||
| async function addComment(page: Page, user: UserEmulator): Promise<void> { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 16 days ago
The best way to fix this issue is to remove the unused addComment function entirely. This will eliminate the warning and improve code clarity. If the function is needed in the future, it can be re-added when the corresponding test or feature is implemented.
Suggested changeset
1
src/SIL.XForge.Scripture/ClientApp/e2e/workflows/community-checking.ts
| @@ -186,8 +186,2 @@ | ||
|
|
||
| // TODO add this to the test | ||
| async function addComment(page: Page, user: UserEmulator): Promise<void> { | ||
| await user.click(page.getByRole('button', { name: /Show \d more unread answers/ })); | ||
| await user.click(page.getByRole('button', { name: 'Add a comment' }).first()); | ||
| await user.type('This is a good answer.'); | ||
| await user.click(page.getByRole('button', { name: 'Save' })); | ||
| } | ||
| // Removed unused function `addComment`. |
Copilot is powered by AI and may make mistakes. Always verify output.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3137 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 568 568
Lines 33062 33062
Branches 5339 5339
=======================================
Hits 27459 27459
+ Misses 4811 4800 -11
- Partials 792 803 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
c6ce63d to
511f1c6
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
511f1c6 to
240ee13
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
240ee13 to
da62195
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
da62195 to
70c712a
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
70c712a to
05107a7
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
05107a7 to
ee77482
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
ee77482 to
a868388
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
a868388 to
8f539c4
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
8f539c4 to
c7d706b
Compare
Nateowami
force-pushed
the
feature/e2e-tests
branch
from
ca6c19a to
afc686e
Compare
| base64 --decode - <<< "${E2E_SECRETS_JSON_BASE64}" > ./ClientApp/e2e/secrets.json | ||
|
|
||
| - name: Set up Deno | ||
| uses: denoland/setup-deno@v2 |
Check failure
Code scanning / zizmor
action is not pinned to a hash (required by blanket policy) Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is