Skip to content

WIP SF-3319 Configure draft usfm #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Apr 23, 2025

This is the working concept for the configure USFM feature for drafts. It shows that you can navigate to the chapter and open a tab for the draft. Then the user can update the configuration on their project and the draft will show the version of the chapter with the select USFM configuration.

image (4)


This change is Reviewable

@RaymondLuong3 RaymondLuong3 force-pushed the feature/sf-3319-configure-usfm-formatting branch from e3b9fdb to f715240 Compare April 25, 2025 21:45
Copy link

codecov bot commented Apr 25, 2025

❌ 16 Tests Failed:

Tests completed Failed Passed Skipped
3881 16 3865 4
View the top 3 failed test(s) by shortest run time
.DraftHandlingService getAndApplyDraftAsync DraftHandlingService getAndApplyDraftAsync should not apply legacy USFM draft
Stack Traces | 0.002s run time
TypeError: Cannot read properties of null (reading 'pipe')
    at DraftHandlingService.getDraft (.../translate/draft-generation/draft-handling.service.ts:165:12)
    at executor (.../translate/draft-generation/draft-handling.service.ts:232:12)
    at new ZoneAwarePromise (node_modules/zone.js/fesm2015/zone.js:2702:25)
    at .../translate/draft-generation/draft-handling.service.ts:231:18
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (node_modules/@.../helpers/esm/asyncToGenerator.js:3:1)
    at _next (node_modules/@.../helpers/esm/asyncToGenerator.js:17:1)
    at executor (node_modules/@.../helpers/esm/asyncToGenerator.js:22:1)
    at new ZoneAwarePromise (node_modules/zone.js/fesm2015/zone.js:2702:25)
    at node_modules/@.../helpers/esm/asyncToGenerator.js:14:1
.DraftHandlingService getAndApplyDraftAsync DraftHandlingService getAndApplyDraftAsync should return false if applying a draft fails
Stack Traces | 0.002s run time
TypeError: Cannot read properties of null (reading 'pipe')
    at DraftHandlingService.getDraft (.../translate/draft-generation/draft-handling.service.ts:165:12)
    at executor (.../translate/draft-generation/draft-handling.service.ts:232:12)
    at new ZoneAwarePromise (node_modules/zone.js/fesm2015/zone.js:2702:25)
    at .../translate/draft-generation/draft-handling.service.ts:231:18
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (node_modules/@.../helpers/esm/asyncToGenerator.js:3:1)
    at _next (node_modules/@.../helpers/esm/asyncToGenerator.js:17:1)
    at executor (node_modules/@.../helpers/esm/asyncToGenerator.js:22:1)
    at new ZoneAwarePromise (node_modules/zone.js/fesm2015/zone.js:2702:25)
    at node_modules/@.../helpers/esm/asyncToGenerator.js:14:1
.DraftHandlingService getDraft DraftHandlingService getDraft should get a draft
Stack Traces | 0.002s run time
TypeError: Cannot read properties of null (reading 'pipe')
    at DraftHandlingService.getDraft (.../translate/draft-generation/draft-handling.service.ts:165:12)
    at UserContext.apply (.../translate/draft-generation/draft-handling.service.spec.ts:75:10)
    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:369:28)
    at ProxyZoneSpec.onInvoke (node_modules/zone.js/fesm2015/zone-testing.js:2081:39)
    at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:368:34)
    at ZoneImpl.run (node_modules/zone.js/fesm2015/zone.js:111:43)
    at runInTestZone (node_modules/zone.js/fesm2015/zone-testing.js:216:38)
    at UserContext.<anonymous> (node_modules/zone.js/fesm2015/zone-testing.js:234:32)
    at <Jasmine>

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@josephmyers
Copy link
Collaborator

I'd be interested in seeing the other design options fleshed out here, as to my knowledge the team never discussed which design would be best. Maybe you received better or more recent guidance? I'm up for a video call, to get on the same page here.

@josephmyers josephmyers self-assigned this Apr 28, 2025
@RaymondLuong3
Copy link
Collaborator Author

@josephmyers Let's plan to do a video call in the next day or so. I'll send you an invitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants