String intern

jadx-core/src/main/java/jadx/core/dex/info/ClassInfo.java

@@ -171,11 +171,11 @@ private void splitAndApplyNames(RootNode root, ArgType type, boolean canBeInner)
 			}
 		}
 		if (!innerCls) {
-			pkg = clsPkg;
+			pkg = clsPkg.intern();
 			parentClass = null;
 		}
-		this.name = clsName;
-		this.fullName = makeFullName();
+		this.name = clsName.intern();
+		this.fullName = makeFullName().intern();
 	}
 
 	private static String makeFullClsName(String pkg, String shortName, ClassInfo parentClass, boolean alias, boolean raw) {

jadx-core/src/main/java/jadx/core/dex/info/FieldInfo.java

@@ -17,9 +17,9 @@ public final class FieldInfo implements IFieldInfoRef {
 
 	private FieldInfo(ClassInfo declClass, String name, ArgType type) {
 		this.declClass = declClass;
-		this.name = name;
+		this.name = name.intern();
 		this.type = type;
-		this.alias = name;
+		this.alias = name.intern();
 	}
 
 	public static FieldInfo from(RootNode root, ClassInfo declClass, String name, ArgType type) {

jadx-core/src/main/java/jadx/core/dex/info/MethodInfo.java

@@ -19,19 +19,17 @@ public final class MethodInfo implements Comparable<MethodInfo> {
 	private final List<ArgType> argTypes;
 	private final ClassInfo declClass;
 	private final String shortId;
-	private final String rawFullId;
 	private final int hash;
 
 	private String alias;
 
 	private MethodInfo(ClassInfo declClass, String name, List<ArgType> args, ArgType retType) {
-		this.name = name;
-		this.alias = name;
+		this.name = name.intern();
+		this.alias = name.intern();
 		this.declClass = declClass;
 		this.argTypes = args;
 		this.retType = retType;
-		this.shortId = makeShortId(name, argTypes, retType);
-		this.rawFullId = declClass.makeRawFullName() + '.' + shortId;
+		this.shortId = makeShortId(name, argTypes, retType).intern();
 		this.hash = calcHashCode();
 	}
 
@@ -115,7 +113,7 @@ public String getFullId() {
 	}
 
 	public String getRawFullId() {
-		return rawFullId;
+		return declClass.makeRawFullName() + '.' + shortId;
 	}
 
 	/**

jadx-core/src/main/java/jadx/core/dex/info/PackageInfo.java

@@ -42,9 +42,9 @@ public static synchronized PackageInfo fromShortName(RootNode root, @Nullable Pa
 	}
 
 	private PackageInfo(String fullName, @Nullable PackageInfo parentPkg, String name) {
-		this.fullName = fullName;
+		this.fullName = fullName.intern();
 		this.parentPkg = parentPkg;
-		this.name = name;
+		this.name = name.intern();
 	}
 
 	public boolean isRoot() {

jadx-core/src/main/java/jadx/core/dex/instructions/args/ArgType.java

@@ -225,7 +225,7 @@ private static class ObjectType extends KnownType {
 		protected final String objName;
 
 		public ObjectType(String obj) {
-			this.objName = obj;
+			this.objName = obj.intern();
 			this.hash = objName.hashCode();
 		}
 

jadx-plugins/jadx-dex-input/src/main/java/jadx/plugins/input/dex/sections/DexFieldData.java

@@ -33,7 +33,7 @@ public String getParentClassType() {
 	}
 
 	public void setParentClassType(String parentClassType) {
-		this.parentClassType = parentClassType;
+		this.parentClassType = parentClassType.intern();
 	}
 
 	@Override
@@ -42,7 +42,7 @@ public String getType() {
 	}
 
 	public void setType(String type) {
-		this.type = type;
+		this.type = type.intern();
 	}
 
 	@Override

jadx-plugins/jadx-dex-input/src/main/java/jadx/plugins/input/dex/sections/annotations/AnnotationsParser.java

@@ -146,7 +146,7 @@ public static IAnnotation readAnnotation(SectionReader in, SectionReader ext, bo
 		int size = in.readUleb128();
 		Map<String, EncodedValue> values = new LinkedHashMap<>(size);
 		for (int i = 0; i < size; i++) {
-			String name = ext.getString(in.readUleb128());
+			String name = ext.getString(in.readUleb128()).intern();
 			values.put(name, EncodedValueParser.parseValue(in, ext));
 		}
 		String type = ext.getType(typeIndex);

jadx-plugins/jadx-input-api/src/main/java/jadx/api/plugins/input/data/annotations/EncodedValue.java

@@ -15,7 +15,11 @@ public class EncodedValue extends PinnedAttribute {
 
 	public EncodedValue(EncodedType type, Object value) {
 		this.type = type;
-		this.value = value;
+		if (type == EncodedType.ENCODED_STRING) {
+			this.value = ((String) value).intern();
+		} else {
+			this.value = value;
+		}
 	}
 
 	public EncodedType getType() {

jadx-plugins/jadx-input-api/src/main/java/jadx/api/plugins/input/data/annotations/JadxAnnotation.java

@@ -9,7 +9,7 @@ public class JadxAnnotation implements IAnnotation {
 
 	public JadxAnnotation(AnnotationVisibility visibility, String type, Map<String, EncodedValue> values) {
 		this.visibility = visibility;
-		this.type = type;
+		this.type = type.intern();
 		this.values = values;
 	}
 

jadx-plugins/jadx-input-api/src/main/java/jadx/api/plugins/input/data/attributes/types/AnnotationsAttr.java

@@ -24,7 +24,7 @@ public static AnnotationsAttr pack(List<IAnnotation> annotationList) {
 		Map<String, IAnnotation> annMap = new HashMap<>(annotationList.size());
 		for (IAnnotation ann : annotationList) {
 			if (ann.getVisibility() != AnnotationVisibility.SYSTEM) {
-				annMap.put(ann.getAnnotationClass(), ann);
+				annMap.put(ann.getAnnotationClass().intern(), ann);
 			}
 		}
 		if (annMap.isEmpty()) {

jadx-plugins/jadx-java-input/src/main/java/jadx/plugins/input/java/data/DataReader.java

@@ -114,7 +114,7 @@ public List<String> readClassesList(ConstPoolReader constPool) {
 		}
 		List<String> list = new ArrayList<>(len);
 		for (int i = 0; i < len; i++) {
-			list.add(constPool.getClass(readU2()));
+			list.add(constPool.getClass(readU2()).intern());
 		}
 		return list;
 	}

jadx-plugins/jadx-java-input/src/main/java/jadx/plugins/input/java/data/attributes/EncodedValueReader.java

@@ -36,15 +36,15 @@ public static EncodedValue read(JavaClassData clsData, DataReader reader) {
 			case 'Z':
 				return new EncodedValue(EncodedType.ENCODED_BOOLEAN, 1 == constPool.getInt(reader.readU2()));
 			case 's':
-				return new EncodedValue(EncodedType.ENCODED_STRING, constPool.getUtf8(reader.readU2()));
+				return new EncodedValue(EncodedType.ENCODED_STRING, constPool.getUtf8(reader.readU2()).intern());
 
 			case 'e':
-				String cls = constPool.getUtf8(reader.readU2());
-				String name = constPool.getUtf8(reader.readU2());
+				String cls = constPool.getUtf8(reader.readU2()).intern();
+				String name = constPool.getUtf8(reader.readU2()).intern();
 				return new EncodedValue(EncodedType.ENCODED_ENUM, new JadxFieldRef(cls, name, cls));
 
 			case 'c':
-				return new EncodedValue(EncodedType.ENCODED_TYPE, constPool.getUtf8(reader.readU2()));
+				return new EncodedValue(EncodedType.ENCODED_TYPE, constPool.getUtf8(reader.readU2()).intern());
 
 			case '@':
 				return new EncodedValue(EncodedType.ENCODED_ANNOTATION,

jadx-plugins/jadx-java-input/src/main/java/jadx/plugins/input/java/data/attributes/types/JavaAnnotationsAttr.java

@@ -52,7 +52,7 @@ public static JadxAnnotation readAnnotation(AnnotationVisibility visibility, Jav
 		for (int j = 0; j < pairsCount; j++) {
 			String name = constPool.getUtf8(reader.readU2());
 			EncodedValue value = EncodedValueReader.read(clsData, reader);
-			pairs.put(name, value);
+			pairs.put(name.intern(), value);
 		}
 		return new JadxAnnotation(visibility, type, pairs);
 	}