fix(res): chunk parsing was aborted too early for unordered entries #2444
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in #2344 allow to parser resources that are not ordered.
I forgot to also consider the new behavior in the code that stops reading entries that are located outside of the chunk.
The old behavior with ordered entries was to stop parsing if we have reached the end of the chunk. Now with unordered entries we can't stop parsing when we reached the end of the chunk because the next entry may have a lower offset and thus may be located again inside the chunk.
Without this change entries may be ignored even so they are fully valid. In the sample app mentioned in #2343 all 15 entries of
resources.arsc/res/values/bools.xmlare now present instead of only 5 without this PR.