C++: make sure we do not crash if a Model::row_data returns nullopt
#8568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
reviewed
May 28, 2025
api/cpp/include/slint_models.h
Outdated
| c.state = State::Clean; | ||
| if (auto data = model->row_data(index)) { | ||
| (*c.ptr)->update_data(index, *data); | ||
| c.state = State::Clean; |
There was a problem hiding this comment.
I'm not an expert here, but wouldn't it make more sense to move this line outside the if block so the state is set to clean even if the model returns nullopt?
tronical
approved these changes
May 30, 2025
Rust had a test for it, but C++ not yet Reported on https://chat.slint.dev/public/pl/pcqefc3fbff3xfuio3uhp58ate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust had a test for it, but C++ not yet
Reported on https://chat.slint.dev/public/pl/pcqefc3fbff3xfuio3uhp58ate