Expose FocusEventReason to .slint as an argument in focus-event-changed and add focus-gained and focus-lost callbacks
#8569
Conversation
internal/core/platform.rs
Outdated
| @@ -282,6 +282,9 @@ pub fn duration_until_next_timer_update() -> Option<core::time::Duration> { | |||
| pub use crate::input::key_codes::Key; | |||
| pub use crate::input::PointerEventButton; | |||
|
|
|||
| // reexport focus reason enum to the public api | |||
| pub use crate::input::FocusEventReason; | |||
There was a problem hiding this comment.
I think it doesn't need to be in the public API.
The test can keep using the private API
There was a problem hiding this comment.
Sorry, still getting acquainted with the project structure, how would I access it via the private API in the test?
There was a problem hiding this comment.
The test can use slint::private_unstable_api::re_exports::FocusEventReason
internal/common/enums.rs
Outdated
| @@ -131,6 +131,20 @@ macro_rules! for_each_enums { | |||
| Action, | |||
| } | |||
|
|
|||
| /// This enum describes the different reasons for a FocusEvent | |||
| enum FocusEventReason { | |||
There was a problem hiding this comment.
Maybe this should be named FocusReason? Or FocusChangeReason ?
internal/common/enums.rs
Outdated
| /// This enum describes the different reasons for a FocusEvent | ||
| enum FocusEventReason { | ||
| /// The keyboard caused the event (tabbing) | ||
| Keyboard, |
There was a problem hiding this comment.
Maybe KeyboardNavigation or KeyboardShortcut
In slint it would then be FocusReason.keyboard or FocusReason.keyboard-navigation or FocusReason.keyboard-shortcut
Or maybe TabKey ?
internal/common/enums.rs
Outdated
| /// The keyboard caused the event (tabbing) | ||
| Keyboard, | ||
| /// The mouse caused the event | ||
| Mouse, |
internal/common/enums.rs
Outdated
| /// A built-in function caused the event (set-focus-item, clear-focus-item) | ||
| BuiltinFunction, |
There was a problem hiding this comment.
Maybe this could be Programmatic
internal/common/enums.rs
Outdated
| /// The window manager changed the active window and caused the event | ||
| ActiveWindow, |
internal/common/enums.rs
Outdated
| /// The mouse caused the event | ||
| Mouse, | ||
| /// A popup caused the event | ||
| Popup, |
codeshaunted
force-pushed
the
avery/focus-reason-callback
branch
from
70b44c6 to
432ab67
Compare
…lost callbacks, closes slint-ui#8387
codeshaunted
force-pushed
the
avery/focus-reason-callback
branch
from
432ab67 to
237b9f4
Compare
|
I've renamed the the variants and the enum based on your suggestions, I also had a bit of a git mishap and had to force push everything again here. Sorry about that 😅 |
This exposes
FocusEventReasonto .slint, and adds it as an argument tofocus-event-changedcallback onFocusScopeto close #8387. It also adds two new callbacks,focus-gainedandfocus-lost, which are identical tofocus-event-changedbut are only invoked on focus gain or loss respectively.In addition to this, it removes the
FocusEventReason::AccessKitvariant, replacing it with the mouse variant to hopefully make AccessKit more compatible with any Slint code that will useFocusEventReason.Finally, I added two tests based on
focus_change_event.slint, one for testing theFocusEventReasonargument and another for testing the new callbacks.