interpreter: Make the From<ModelRc> for Value implement set_row_data
#8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting a ModelRc<T> to a Value, the resulting model did not implement set_row_data and therefore would not allow changing the model from the code. By adding a `TryFrom` bound, we can make sure set_row_data is implemented. This is technically a breaking change to add this bound, but most type that implement From for value also implement TryFrom<Value> These conversion function were added in 20443ec for Slint 1.9
ogoffart
force-pushed
the
olivier/interpreter
branch
from
ba1f4d2 to
cfd06d8
Compare
tronical
approved these changes
May 30, 2025
| } | ||
|
|
||
| fn as_any(&self) -> &dyn core::any::Any { | ||
| self |
There was a problem hiding this comment.
Shouldn't that forward to the inner model?
There was a problem hiding this comment.
I was thinking about it.
This would allow something like
// foo is a ModelRc<Value> that was build from a ModelRc wrapping a VecModel<SharedString>
foo.as_any().downcast_ref::<VecModel<SharedString>>()But then it gets harder to make the following work
let xxx : ModelRc<SharedString> = value.try_into().unwrap()
as the m.as_any().downcast_ref::<crate::value_model::ValueMapModel<T>> wouldn't work anymore
There was a problem hiding this comment.
That's exactly the what I was thinking of (the first case).
For the second case, I'm not sure I understand. Who needs to perform the downcast to the wrapper model? Is the issue that you'd like to get a clone instead of a ref?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a ModelRc to a Value, the resulting model did not implement set_row_data and therefore would not allow changing the model from the code.
By adding a
TryFrombound, we can make sure set_row_data is implemented.This is technically a breaking change to add this bound, but most type that implement From for value also implement TryFrom
These conversion function were added in
20443ec for Slint 1.9