Skip to content

Andrew/ts config2 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2025
Merged

Andrew/ts config2 #104

merged 8 commits into from
Jun 10, 2025

Conversation

smartyandrewb
Copy link
Contributor

@smartyandrewb smartyandrewb commented May 2, 2025

https://app.clickup.com/t/86b4n64h5

this allows the sdk to have typescript in it. We want to make sure that it works with both esm and cjs.

Copy link
Contributor

@maxwellpothier maxwellpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested our react and vue examples, as well as scripts using both cjs and esm, and all seem to be working as expected.

@maxwellpothier maxwellpothier self-requested a review May 30, 2025 16:06
@smartyandrewb smartyandrewb requested a review from camiblanch June 9, 2025 14:39
package.json Outdated
"axios-retry": "^4.5.0"
"axios": "^1.9.0",
"axios-retry": "^4.5.0",
"tslib": "^2.8.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this dependency? I don't see it referenced anywhere, but maybe I'm not looking in the right place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I don't think we need this

export default class Sleeper {
constructor () {}
sleep(seconds: number) {
return new Promise<void>((resolve: () => void) => setTimeout(resolve, seconds*1000));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to state the type here for resolve since it's already defined by the Promise class. Having it here feels redundant

@smartyandrewb smartyandrewb merged commit a4ef663 into master Jun 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants