Skip to content

Andrew/ts config2 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Andrew/ts config2 #104

wants to merge 7 commits into from
+1,572 −1,108

Conversation

smartyandrewb
Copy link
Contributor

@smartyandrewb smartyandrewb commented May 2, 2025 •
edited
Loading

https://app.clickup.com/t/86b4n64h5

this allows the sdk to have typescript in it. We want to make sure that it works with both esm and cjs.

maxwellpothier
maxwellpothier requested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@maxwellpothier maxwellpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested our react and vue examples, as well as scripts using both cjs and esm, and all seem to be working as expected.

@maxwellpothier maxwellpothier self-requested a review May 30, 2025 16:06
@smartyandrewb smartyandrewb requested a review from camiblanch June 9, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellpothier maxwellpothier maxwellpothier approved these changes

@camiblanch camiblanch Awaiting requested review from camiblanch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smartyandrewb @maxwellpothier