Andrew/ts config2 #104
Merged
Andrew/ts config2 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwellpothier
requested changes
May 29, 2025
maxwellpothier
approved these changes
May 30, 2025
camiblanch
requested changes
Jun 9, 2025
package.json
Outdated
| "axios-retry": "^4.5.0" | ||
| "axios": "^1.9.0", | ||
| "axios-retry": "^4.5.0", | ||
| "tslib": "^2.8.1" |
There was a problem hiding this comment.
What's the purpose of this dependency? I don't see it referenced anywhere, but maybe I'm not looking in the right place
There was a problem hiding this comment.
Good catch, I don't think we need this
src/util/Sleeper.ts
Outdated
| export default class Sleeper { | ||
| constructor () {} | ||
| sleep(seconds: number) { | ||
| return new Promise<void>((resolve: () => void) => setTimeout(resolve, seconds*1000)); |
There was a problem hiding this comment.
I think we don't need to state the type here for resolve since it's already defined by the Promise class. Having it here feels redundant
camiblanch
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86b4n64h5
this allows the sdk to have typescript in it. We want to make sure that it works with both esm and cjs.