-
Notifications
You must be signed in to change notification settings - Fork 33
Andrew/ts config2 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Andrew/ts config2 #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested our react and vue examples, as well as scripts using both cjs and esm, and all seem to be working as expected.
package.json
Outdated
"axios-retry": "^4.5.0" | ||
"axios": "^1.9.0", | ||
"axios-retry": "^4.5.0", | ||
"tslib": "^2.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this dependency? I don't see it referenced anywhere, but maybe I'm not looking in the right place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I don't think we need this
src/util/Sleeper.ts
Outdated
export default class Sleeper { | ||
constructor () {} | ||
sleep(seconds: number) { | ||
return new Promise<void>((resolve: () => void) => setTimeout(resolve, seconds*1000)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to state the type here for resolve
since it's already defined by the Promise class. Having it here feels redundant
https://app.clickup.com/t/86b4n64h5
this allows the sdk to have typescript in it. We want to make sure that it works with both esm and cjs.