Skip to content

Removing the optimize_crc32_auto feature flag from the crc-fast #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

landonxjames
Copy link
Contributor

@landonxjames landonxjames commented May 19, 2025

Motivation and Context

Removing the optimize_crc32_auto feature flag from the crc-fast dependency of the aws-smithy-checksums crate since it was causing build issues for some customers.

awslabs/aws-sdk-rust#1291

Description

Testing

Tested in an Amazon Linux 2023 Docker Container on an M1 Mac. Both cargo lambda build --arm64 and cargo lambda build --x86-64 succeeded with this change

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@landonxjames landonxjames changed the title Landonxjames/crc feature Removing the optimize_crc32_auto feature flag from the crc-fast May 19, 2025
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@landonxjames landonxjames marked this pull request as ready for review May 19, 2025 20:32
@landonxjames landonxjames requested review from a team as code owners May 19, 2025 20:32
@landonxjames landonxjames merged commit 4e4a0ee into main May 19, 2025
44 checks passed
@landonxjames landonxjames deleted the landonxjames/crc-feature branch May 19, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants