Fix jsonName conversion for OpenAPI examples #2666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates AbstractRestProtocol's value transformer to take the conversion context and the shape of the value it is transforming.
This updates the OpenAPI conversion to apply the jsonName trait if said trait is enabled.
JordonPhillips
changed the title
sugmanue
reviewed
Jun 13, 2025
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Manuel Sugawara <[email protected]>
sugmanue
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting to OpenAPI for the restJson1 protocol, we convert member names if they have the jsonName trait. However, we were not converting those member names in examples. This updates example conversion to respect member name, if present and enabled.
Fixes #2659
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.