Skip to content

chore(gradle): remove custom startScripts task #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

xeruf
Copy link
Member

@xeruf xeruf commented Jan 20, 2021

Current issues:

https://docs.gradle.org/current/dsl/org.gradle.jvm.application.tasks.CreateStartScripts.html

May fix #265

xeruf added 6 commits January 20, 2021 12:42
The jar task was resolving the default configuration in the configuration phase,
leading to spurious failure when executing any task in the testclient directly.
It was only because of two constants...
Current issues:
- the start-script hardcodes classpath to lib:
  gradle/gradle#7033
- script assumes it is in a bin directory, but I want it in root ("pwd -P")

https://docs.gradle.org/current/dsl/org.gradle.jvm.application.tasks.CreateStartScripts.html
@xeruf xeruf changed the title TEMP chore(gradle): remove custom startScripts task chore(gradle): remove custom startScripts task Jan 20, 2021
@xeruf xeruf force-pushed the chore/gradle/fix-tasks branch from b1678a2 to f1d2f0e Compare January 21, 2021 10:37
Base automatically changed from chore/gradle/fix-tasks to master January 21, 2021 15:41
@xeruf xeruf added this to the long-term milestone Feb 11, 2021
@xeruf xeruf closed this Jun 11, 2021
@xeruf xeruf deleted the branch master June 11, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deploy task with gradle distribution plugin
1 participant