[js-legacy] Fix program check in amountToUiAmount helper functions #444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Program ID Matching Logic
Problem
Currently, the code uses strict equality (
===
) to compare program IDs withTOKEN_PROGRAM_ID
andTOKEN_2022_PROGRAM_ID
. This can lead to false negatives when comparingPublicKey
instances, as they may have different object references even when representing the same underlying public key data.Solution
Replace the strict equality checks with
PublicKey.equals()
method, which properly compares the underlying public key data rather than object references.Changes
amountToUiAmountForMintWithoutSimulation
uiAmountToAmountForMintWithoutSimulation
Testing
PublicKey
instances representing the same program ID