Bump deps [blocked] #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
commented
Apr 30, 2025
Comment on lines
-60
to
-61
| .ok() | ||
| .map(Arc::from); |
There was a problem hiding this comment.
Swallowing the error here resulted in a strange obfuscated error result while debugging an issue with the version bump. Mapping the error to a string instead so it can be read in the future.
grod220
commented
Apr 30, 2025
Comment on lines
-187
to
-193
| ( | ||
| system_program::id(), | ||
| Account { | ||
| executable: true, | ||
| ..Default::default() | ||
| }, | ||
| ), |
There was a problem hiding this comment.
New mollusk version errors on this stub account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required before publishing rust crates as git deps are not allowed.
Waiting on agave v2.3 to be published first.