This repository was archived by the owner on Jan 22, 2019. It is now read-only.
refactor: use non-deprecated GraphQL Repository.name (not uri) #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Repository.uri field in GraphQL (and in general) is deprecated in favor of Repository.name. This is just a different name for the same value (
name
is a better name thanuri
because the value is not actually a URI, souri
is a misnomer). The value that both fields contain is the string of the formgithub.com/foo/bar
for a repository.The GraphQL
Query.repository
resolver also has 2 equivalent args,name
anduri
, and this also changes calls to use the former (for the same reason).There is no change in behavior.
Testing plan:
Query.repository
use thename
arg name and succeed.I have tested on: