use same version of dependencies #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, with the upcoming 0.10 it's the good moment to introduce changes in dependencies versions. Looks like there's a rusftmt issue though. |
|
Looking at the failure, it's an issue I've encountered for #245, and it's fixed there. It's caused by a change in rustmft with the latest rust release. Re-running the tests should work. |
|
No I'm wrong, it needs to be rebased. Alternatively, I can merge it like this, and the merge result should pass the rustfmt test. |
mulimoen
force-pushed
the
deduplicate_dependencies
branch
from
e98db1d to
6c0a8c2
Compare
|
I've rebased on master now |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures all dependencies are the same version