Amend position attribute in startResumePlayback method #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ran into this as well. Would be great to see this merged. |
itsamaik
approved these changes
Mar 14, 2024
|
+1, would be great, if this could be merged👍🏽 |
|
@jordan-loeser @zhammer Hi guys, could you please review this PR and merge it? It would save an extra API call. |
|
It's a simple fix, please merge this PR. |
|
yes please can someone merge this, I don't have the access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlayerEndpoints: Amend the
positionMsparam/body attribute instartResumePlaybackto the correct:position_msProblem
The param and body attribute
positionMsin thestartResumePlaybackmethod inPlayerEndoints.tsis camelCase whereas the documentation says it should be snake_case.Solution
Rename the param and attribute to
position_msResult
Playback will start/resume at the specified postion