feat: add hugging face text to image integration #1162
Conversation
|
thanks you very much, i did the original quick pass around hugging face and appreciate this improvement. |
|
thank you for your response. I wasn't sure if this PR would be considered useful at this moment. However I think I have to make smaller adjustments, as some aspects of the codebase have changed in the meantime, due to other merged PRs, thus marking it as draft. Will take some time, since I'm on vacation right now :D |
|
@markpollack should be now ready to review. If you see any room for improvements, kindly let me know |
d-lobo
force-pushed
the
add-huggingface-text-to-image
branch
from
97e4628 to
89ffb0c
Compare
d-lobo
force-pushed
the
add-huggingface-text-to-image
branch
from
89ffb0c to
0038772
Compare
| import org.springframework.ai.huggingface.model.chat.AllOfGenerateResponseDetails; | ||
| import org.springframework.ai.huggingface.model.chat.GenerateParameters; | ||
| import org.springframework.ai.huggingface.model.chat.GenerateRequest; | ||
| import org.springframework.ai.huggingface.model.chat.GenerateResponse; | ||
|
|
There was a problem hiding this comment.
It looks like your code style settings don't align with those of the project. None of these lines should change
There was a problem hiding this comment.
It's not related to code style, I have changed the buildpath in openapi codegen configuration to improve the package structure of generated code. Is this an undesired change ?
However I used the default code styles of my IDE, changed it now to settings mentioned here: https://github.com/spring-projects/spring-framework/wiki/IntelliJ-IDEA-Editor-Settings
|
Probably going to clash heavily with #486, but then would be a nice addition IMO |
Hi,
I was experimenting with Spring AI and some models deployed on hugging face, realizing that a lot of stuff is missing for huggingface explaining the reason for this PR.
The changes provide a baseline implementation for querying text-to-image models deployed on huggingface.
I tried to align the code as much as possible on the existing implementation for chat models, however in order to support different image types on the api, I was required to add a custom template for swagger codegen, since the default templates generate a priorization for
application/jsonwith regards to the accept header (which in turn allows the generated api to retrieve base64 encoded strings only, leading to the fact, that only PNG images could be generated). This seems unfavorable for an text-to-image api. Thus the modified templates adds the possibility to specify the desired image type on requesting the model.