Adding Vertex AI Imagen models support #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Marzouki-Sami wants to merge 7 commits into spring-projects:main from Marzouki-Sami:gh-2133

Marzouki-Sami commented Jan 29, 2025

Closes gh-2133

Signed-off-by: Marzouki-Sami [email protected]

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

Sign the contributor license agreement
Rebase your changes on the latest main branch and squash your commits
Add/Update unit tests as needed
Run a build and make sure all tests pass prior to submission

Marzouki-Sami marked this pull request as draft

January 29, 2025 07:07

Marzouki-Sami force-pushed the gh-2133 branch from 735bd7d to 965e590 Compare

January 29, 2025 07:10

Marzouki-Sami marked this pull request as ready for review

January 29, 2025 07:12

Member

markpollack commented Jan 29, 2025

@ddobrin can you please take a look?

Contributor

turchinc commented Mar 25, 2025

Any update here? I am also interested in this feature.

markpollack added vertex image models labels

byungjunn commented Mar 27, 2025

I am currently using this feature as a custom-made version. I hope it gets updated soon. If help is needed, I would be willing to participate.

Member

ilayaperumalg commented Mar 27, 2025

@byungjunn Thanks! Any help reviewing the PR is much appreciated.

byungjunn reviewed

View reviewed changes

...ai-imagen/src/main/java/org/springframework/ai/vertexai/imagen/VertexAiImagenImageModel.java Outdated Show resolved Hide resolved

byungjunn reviewed

View reviewed changes

spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated Show resolved Hide resolved

byungjunn reviewed

View reviewed changes

spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated Show resolved Hide resolved

byungjunn reviewed

View reviewed changes

spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated Show resolved Hide resolved

byungjunn reviewed

View reviewed changes

spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated Show resolved Hide resolved

byungjunn commented Mar 28, 2025

@Marzouki-Sami
https://spring.io/blog/2025/03/25/spring-ai-update-to-snapshots
After the update, there have been many changes, so I think you need to rebase onto the main branch.

Marzouki-Sami changed the base branch from 1.0.0-M5 to main

June 5, 2025 11:43

Marzouki-Sami force-pushed the gh-2133 branch from cbff217 to 0e8a0ef Compare

June 12, 2025 14:55

Marzouki-Sami closed this

Marzouki-Sami force-pushed the gh-2133 branch from 0e8a0ef to 384478e Compare

June 16, 2025 10:08

Marzouki-Sami and others added 5 commits

June 16, 2025 11:09


          Adding Vertex AI Imagen models support

489767d

Closes spring-projectsgh-2133

Signed-off-by: Marzouki-Sami [email protected]
Signed-off-by: Marzouki-Sami <[email protected]>


          Update spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-ima…

0fe3fff

…gen/pom.xml


Updating the version.

Co-authored-by: ByungJun <[email protected]>
Signed-off-by: Sami Marzouki <[email protected]>


          Update spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-ima…

67c46d1

…gen/pom.xml


changing artifactId

Co-authored-by: ByungJun <[email protected]>
Signed-off-by: Sami Marzouki <[email protected]>


          Update spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-ima…

adafe0b

…gen/pom.xml


removing unnecessary spaces

Co-authored-by: ByungJun <[email protected]>
Signed-off-by: Sami Marzouki <[email protected]>


          updating artifactId

73c3245

Co-authored-by: ByungJun <[email protected]>
Signed-off-by: Sami Marzouki <[email protected]>

Author

Marzouki-Sami commented Jun 17, 2025

@byungjunn @ilayaperumalg @markpollack i had some issues with resolving the conflict and to resolve the conflict i had to remove the commits, doing that closed this PR is it possible to reopen it, if not i will create a new PR and link it to this one.

ilayaperumalg reopened this

Marzouki-Sami force-pushed the gh-2133 branch 2 times, most recently from 7fef979 to 54f3ba7 Compare

June 17, 2025 09:47

sami.marzouki and others added 2 commits

June 17, 2025 10:49


          resolving conflict

a242b4f

Signed-off-by: Marzouki-Sami <[email protected]>


          updating to version 1.1.0-SNAPSHOT

9b223f9

Signed-off-by: Marzouki-Sami <[email protected]>

Marzouki-Sami force-pushed the gh-2133 branch from 54f3ba7 to 9b223f9 Compare

June 17, 2025 09:50

Author

Marzouki-Sami commented Jun 17, 2025

@byungjunn thanks for the review the mentioned points above are fixed. Can you check them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

image models vertex