Introduce default methods for JdbcChatMemoryRepositoryDialect #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanming Zhou <[email protected]>
|
Thanks, we will address this in 1.0.x release. |
essien
reviewed
May 23, 2025
| */ | ||
| public interface JdbcChatMemoryRepositoryDialect { | ||
|
|
||
| /** | ||
| * Returns the SQL to fetch messages for a conversation, ordered by timestamp, with | ||
| * limit. | ||
| */ | ||
| String getSelectMessagesSql(); | ||
| default String getSelectMessagesSql() { | ||
| return "SELECT content, type FROM SPRING_AI_CHAT_MEMORY WHERE conversation_id = ? ORDER BY " |
There was a problem hiding this comment.
I noticed the table name SPRING_AI_CHAT_MEMORY is in uppercase. Is there a specific reason for this, or would it be okay to change it to lowercase (e.g., spring_ai_chat_memory) to improve readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.