Allow session update for existing session ID even if max sessions limit is reached

[msnsaeed71]

Previously, when saving a session, the system did not check whether the session ID already existed. As a result, even if the session being saved was an update to an existing one, it was incorrectly treated as a new session, and a "maximum sessions exceeded" error was triggered.

This fix ensures that if a session with the same ID already exists, it will be updated rather than counted as a new session, thereby preventing unnecessary session limit violations.

[DhruvTheDev1]

This PR addresses a important logic in session management.

• The updated condition makes sure that only truly new sessions are blocked when the maximum limit is reached.
• If a session with the same ID already exists, it’s treated as an update, not a new session, and is allowed.
• The fix is minimal, targeted, and clearly improves correctness.

Solid improvement!

[sbrannen]

In order to process this PR, we will need a test to verify whether the proposed change is necessary.

Thus, please introduce a test that fails before the change and passes after the change.

Thanks

[msnsaeed71]

This PR addresses a important logic in session management.

• The updated condition makes sure that only truly new sessions are blocked when the maximum limit is reached.
• If a session with the same ID already exists, it’s treated as an update, not a new session, and is allowed.
• The fix is minimal, targeted, and clearly improves correctness.

Solid improvement!

Thank you for the thoughtful review and kind words 🙏
I'm glad the logic refinement is clear and appreciated.

Appreciate your feedback and support!

[msnsaeed71]

In order to process this PR, we will need a test to verify whether the proposed change is necessary.

Thus, please introduce a test that fails before the change and passes after the change.

Thanks

This PR adds a test to confirm that updating an existing session (with the same session ID) is still allowed even when the maximum number of sessions has been reached.
Thanks for the guidance. 🙏