-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftUILists pod #511
base: main
Are you sure you want to change the base?
Add SwiftUILists pod #511
Conversation
1832387
to
3ad6738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never committed before, but I figure it should be like the Demo one for consistency across developers.
Would you be open to doing this on a feature branch until it's ready to be integrated upstream? |
We're not publishing the pod at all, so |
I'd prefer this to go on a feature branch, but don't feel too strongly—maybe let's get one more review with a comment regarding this before merging?
|
So I think I've said this before, but maybe haven't written it down: Feature branches are only useful when, without one, you're going to be forced to ship something buggy or incomplete to your customers – but they come with downsides, eg the longer running they are, the more of a pain it is to merge back and forth, and avoid incongruent changes on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more review addressing feature branch topic
In this context (an open source repo) I would advocate for a feature branch. Even without publishing the pod it would accessible to consume by an eager client. I don't think there's any harm in an empty podspec/framework being available but I probably hold it in a feature branch until some set of functionality was closer to being made available.
Approving because I'm not going to lose sleep over this whether it lands in main or not.
Getting the base targets set up for the SwiftUI interface. I am not including anything in the changelog yet.