Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftUILists pod #511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SwiftUILists pod #511

wants to merge 1 commit into from

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Nov 19, 2023

Getting the base targets set up for the SwiftUI interface. I am not including anything in the changelog yet.

@kyleve kyleve requested a review from a team November 19, 2023 23:37
@kyleve kyleve force-pushed the kve/swiftui-lists-1 branch from 1832387 to 3ad6738 Compare November 19, 2023 23:38
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was never committed before, but I figure it should be like the Demo one for consistency across developers.

@n8chur
Copy link
Collaborator

n8chur commented Nov 20, 2023

Would you be open to doing this on a feature branch until it's ready to be integrated upstream?

@kyleve
Copy link
Collaborator Author

kyleve commented Nov 20, 2023

Would you be open to doing this on a feature branch until it's ready to be integrated upstream?

We're not publishing the pod at all, so main seemed fine to me. This repo doesn't see much action anyway...

@n8chur
Copy link
Collaborator

n8chur commented Nov 20, 2023

I'd prefer this to go on a feature branch, but don't feel too strongly—maybe let's get one more review with a comment regarding this before merging?

  • 1 more review addressing feature branch topic

@kyleve
Copy link
Collaborator Author

kyleve commented Nov 20, 2023

So I think I've said this before, but maybe haven't written it down: Feature branches are only useful when, without one, you're going to be forced to ship something buggy or incomplete to your customers – but they come with downsides, eg the longer running they are, the more of a pain it is to merge back and forth, and avoid incongruent changes on main vs the-feature/branch. This is why instead of feature branches in POS, we tend to leverage feature flags for example. Given that we can just not publish this pod (or any other pods) until they're ready, the feature branch in general is just extra legwork for no benefit, IMO.

@n8chur n8chur requested a review from robmaceachern November 20, 2023 20:59
@n8chur n8chur assigned watt and unassigned watt Nov 20, 2023
@n8chur n8chur requested a review from watt November 20, 2023 21:00
Copy link
Member

@robmaceachern robmaceachern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more review addressing feature branch topic

In this context (an open source repo) I would advocate for a feature branch. Even without publishing the pod it would accessible to consume by an eager client. I don't think there's any harm in an empty podspec/framework being available but I probably hold it in a feature branch until some set of functionality was closer to being made available.

Approving because I'm not going to lose sleep over this whether it lands in main or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants