-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore: add spark 3.5.6 #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
razvan
wants to merge
10
commits into
main
Choose a base branch
from
chore/spark-3.5.6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: add spark 3.5.6 #1142
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0449c9d
chore: bump spark version to 3.5.6
razvan f760876
chore: update spark-connect-client to 3.5.6
razvan 0f30f94
update changelog
razvan d780c3e
update pr no
razvan e47ac6a
fix typo
razvan 18d3ec0
Merge branch 'main' into chore/spark-3.5.6
razvan 884681e
Merge branch 'main' into chore/spark-3.5.6
razvan 41fb01a
Merge branch 'main' into chore/spark-3.5.6
razvan e8d1c3d
fix md lint
razvan 7564c4f
Merge branch 'main' into chore/spark-3.5.6
razvan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
spark-k8s/stackable/patches/3.5.6/0001-Update-CycloneDX-plugin.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| From 94ccf32b4d0eb7c3191b4e5a646605e7386c39ff Mon Sep 17 00:00:00 2001 | ||
| From: Razvan-Daniel Mihai <[email protected]> | ||
| Date: Tue, 11 Mar 2025 17:29:39 +0200 | ||
| Subject: Update CycloneDX plugin | ||
|
|
||
| --- | ||
| dev/make-distribution.sh | 1 - | ||
| pom.xml | 7 ++++++- | ||
| 2 files changed, 6 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/dev/make-distribution.sh b/dev/make-distribution.sh | ||
| index ef7c010e93..0f4c1c74e4 100755 | ||
| --- a/dev/make-distribution.sh | ||
| +++ b/dev/make-distribution.sh | ||
| @@ -171,7 +171,6 @@ BUILD_COMMAND=("$MVN" clean package \ | ||
| -Dmaven.javadoc.skip=true \ | ||
| -Dmaven.scaladoc.skip=true \ | ||
| -Dmaven.source.skip \ | ||
| - -Dcyclonedx.skip=true \ | ||
| $@) | ||
|
|
||
| # Actually build the jar | ||
| diff --git a/pom.xml b/pom.xml | ||
| index 68e2c422a2..6216ebb08e 100644 | ||
| --- a/pom.xml | ||
| +++ b/pom.xml | ||
| @@ -3534,7 +3534,12 @@ | ||
| <plugin> | ||
| <groupId>org.cyclonedx</groupId> | ||
| <artifactId>cyclonedx-maven-plugin</artifactId> | ||
| - <version>2.7.9</version> | ||
| + <version>2.8.0</version> | ||
| + <configuration> | ||
| + <projectType>application</projectType> | ||
| + <schemaVersion>1.5</schemaVersion> | ||
| + <skipNotDeployed>false</skipNotDeployed> | ||
| + </configuration> | ||
| <executions> | ||
| <execution> | ||
| <phase>package</phase> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| base = "303c18c74664f161b9b969ac343784c088b47593" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is deprecated, not removed in this release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the client it being removed as it is only used in demos.
If it is being used in tests, it will need to stay in for the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spark connect support is experimental has not been released yet. The tests are performed with the version of our choosing which has been 3.5.5 until now but we update it to 3.5.6.
There is no requirement to keep the connect client for 3.5.5 around, unless we discover major bugs with 3.5.6.