Skip to content

chore: Use the default profile for the stable Rust toolchain #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jun 2, 2025

This fixes the current pre-commit (clippy) failures by installing the "default" profile.

In the future, we want to instead explicitly list the components for each toolchain in the pre-commit action instead. This will internally most likely use a custom "install rust" action which allows to install multiple toolchains at once.

@Techassi Techassi self-assigned this Jun 2, 2025
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Jun 2, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Techassi Techassi added this pull request to the merge queue Jun 2, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jun 2, 2025
Merged via the queue into main with commit c91c7ff Jun 2, 2025
8 checks passed
@Techassi Techassi deleted the chore/rust-stable-profile branch June 2, 2025 14:44
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants