Feature: CDN distribution resource and data source #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malteehrlen As said in the PR template, please link an GitHub issue or at least add a description which describes what you want to achieve within your PR. |
malteehrlen
force-pushed
the
cdn/me/distribution_resource
branch
4 times, most recently
from
5e6d900 to
bc7c08b
Compare
malteehrlen
changed the title
malteehrlen
force-pushed
the
cdn/me/distribution_resource
branch
3 times, most recently
from
e534c17 to
47e290c
Compare
malteehrlen
force-pushed
the
cdn/me/distribution_resource
branch
from
47e290c to
4a2267f
Compare
malteehrlen
requested review from
marceljk,
bahkauv70,
Fyusel and
rubenhoenle
as code owners
|
@rubenhoenle I have now published the PR for review, please have a look. |
h3adex
reviewed
Apr 25, 2025
stackit/provider.go
Outdated
| @@ -463,6 +473,7 @@ func (p *Provider) Configure(ctx context.Context, req provider.ConfigureRequest, | |||
| // DataSources defines the data sources implemented in the provider. | |||
| func (p *Provider) DataSources(_ context.Context) []func() datasource.DataSource { | |||
| return []func() datasource.DataSource{ | |||
| cdn.NewDistributionDataSource, | |||
| @@ -105,6 +106,17 @@ func ObservabilityProviderConfig() string { | |||
| ObservabilityCustomEndpoint, | |||
| ) | |||
| } | |||
| func CdnProviderConfig() string { | |||
| if CdnCustomEndpoint == "" { | |||
| return `provider "stackit" {}` | |||
There was a problem hiding this comment.
default_region attribute missing
There was a problem hiding this comment.
cdn is a global resource without region
| "config": "The distribution configuration", | ||
| "config_backend": "The configured backend for the distribution", | ||
| "config_regions": "The configured regions where content will be hosted", | ||
| "config_backend_type": "the ", |
|
|
||
| func (r *distributionResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) { | ||
| descriptions := map[string]string{ | ||
| "id": "Terrform resource ID", |
There was a problem hiding this comment.
how is the id built. check how it is described for other resources
| }, | ||
| }, | ||
| }, | ||
| "regions": schema.ListAttribute{ |
| if resp.Diagnostics.HasError() { | ||
| return | ||
| } | ||
| if model.ProjectId.IsUnknown() || model.ProjectId.IsNull() { |
|
|
||
| func (r *distributionDataSource) Schema(_ context.Context, _ datasource.SchemaRequest, resp *datasource.SchemaResponse) { | ||
| descriptions := map[string]string{ | ||
| "id": "Terrform resource ID", |
There was a problem hiding this comment.
documentation on id missing
| "config": "The distribution configuration", | ||
| "config_backend": "The configured backend for the distribution", | ||
| "config_regions": "The configured regions where content will be hosted", | ||
| "config_backend_type": "the ", |
| } | ||
|
|
||
| func (r *distributionDataSource) Schema(_ context.Context, _ datasource.SchemaRequest, resp *datasource.SchemaResponse) { | ||
| descriptions := map[string]string{ |
There was a problem hiding this comment.
I've created on description map in the resource go and used it for the datasource as well. Easier to maintain.
| }, | ||
| }, | ||
| }, | ||
| "regions": schema.ListAttribute{ |
malteehrlen
force-pushed
the
cdn/me/distribution_resource
branch
from
cf33d95 to
36538a5
Compare
malteehrlen
force-pushed
the
cdn/me/distribution_resource
branch
from
36538a5 to
c1e165e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)