-
Notifications
You must be signed in to change notification settings - Fork 696
state machine updates for tx replay #6020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state machine updates for tx replay #6020
Conversation
…o feat/fork-detection-state-machine
Current state of this PR:
|
…ransactions Signed-off-by: Jacinta Ferrant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just a few comments
All comments addressed, plz re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixed a conflict, re-requesting reviews 🙏 |
0022c19
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6020 +/- ##
===========================================
+ Coverage 73.43% 83.33% +9.89%
===========================================
Files 538 538
Lines 388534 389065 +531
Branches 323 323
===========================================
+ Hits 285306 324210 +38904
+ Misses 103220 64847 -38373
Partials 8 8
... and 261 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR implements:
Vec<StacksTransaction>
in state machine updatesThis builds on top of #6048 (which we should merge first)