-
-
Notifications
You must be signed in to change notification settings - Fork 116
Issue/870 affine xform clarification #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it intentional to update the submodule? I'm not 100% sure how that works.
The only major required change is for the model blocks---everything else is just style.
vector<multiplier=exp(y/2)>[9] x; | ||
} | ||
model { | ||
y ~ std_normal(); // implies y ~ normal(0, 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same issue as above.
transformed parameter. | ||
sampled as independent standard normals, which is easy for Stan, | ||
and then transformed into samples from the funnel. | ||
When this reparameterization is used in Stan code, a comment indicating what the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although they are technically reparameterizations under the hood, I think we should stick to calling them transforms. The terminology is confusing if you have any suggestions---the problem is that with the affine transform there is no constraining or unconstraining. The domain and range of the transform function are the same---it's just a bijection over the whole real number line.
The submodule changes should not be committed here |
I don't know how or why the quarto-config was touched by this PR and I have spent the past hour trying to undo this. |
Try
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor tweaks.
Submission Checklist
<<{ since VERSION }>>
Summary
Minor clarifications to Reference Manual on affine transform, added example of Neal's funnel using affine xform to Stan User's Guide chapter on efficiency tuning.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: