Skip to content

feat(deployment): add sequencer liveness check stage to system test workflow #6645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow
Choose a base branch
from
Open

feat(deployment): add sequencer liveness check stage to system test workflow #6645

wants to merge 1 commit into from

Conversation

nadin-Starkware
Copy link
Collaborator

No description provided.

@nadin-Starkware nadin-Starkware marked this pull request as ready for review May 21, 2025 13:21
@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced May 21, 2025
Merged
Merged
Merged
Merged
@nadin-Starkware Graphite App
Copy link
Collaborator Author

nadin-Starkware commented May 21, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nadin-Starkware nadin-Starkware mentioned this pull request May 21, 2025
Open
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from b641a04 to 5cb1b1a Compare May 21, 2025 13:40
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 6755a59 to 6dc5a42 Compare May 21, 2025 13:40
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 5cb1b1a to b163166 Compare May 21, 2025 13:42
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch 2 times, most recently from 5bd0442 to 85b2699 Compare May 21, 2025 13:47
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch 2 times, most recently from 2ac5d37 to f460da6 Compare May 21, 2025 14:11
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 85b2699 to c251335 Compare May 21, 2025 14:11
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from f460da6 to 1a93b03 Compare May 21, 2025 14:13
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from c251335 to 701000e Compare May 21, 2025 14:13
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 1a93b03 to d60c767 Compare May 21, 2025 14:17
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 701000e to 55ef9f1 Compare May 21, 2025 14:17
Itay-Tsabary-Starkware
Itay-Tsabary-Starkware requested changes May 21, 2025
View reviewed changes
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

scripts/system_tests/liveness_check.py line 83 at r2 (raw file):

        monitoring_port = get_monitoring_port(full_config_path)

        local_port = monitoring_port + i

?

Code quote:

local_port = monitoring_port + i

@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 55ef9f1 to 6399f64 Compare May 22, 2025 06:55
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from d60c767 to 55ab6dc Compare May 22, 2025 06:55
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 6399f64 to ae841e3 Compare May 22, 2025 07:04
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 55ab6dc to 25581a3 Compare May 22, 2025 07:04
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from ae841e3 to f8a2b9f Compare May 22, 2025 08:06
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 25581a3 to 17cc4cd Compare May 22, 2025 08:06
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from f8a2b9f to 3a68e16 Compare May 22, 2025 08:12
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 17cc4cd to c404882 Compare May 22, 2025 08:12
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 3a68e16 to 711b52f Compare May 22, 2025 08:14
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from c404882 to e5ac4ce Compare May 22, 2025 08:14
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 711b52f to f89200a Compare May 22, 2025 08:20
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from e5ac4ce to 1bfdb6f Compare May 22, 2025 08:20
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from f89200a to 04e7fc7 Compare May 22, 2025 08:21
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 1bfdb6f to 6203c67 Compare May 22, 2025 08:21
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 04e7fc7 to 8d3ec34 Compare May 22, 2025 08:31
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from 6203c67 to 7d78d2b Compare May 22, 2025 08:31
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 8d3ec34 to d81b38e Compare May 22, 2025 08:31
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch 2 times, most recently from 9763f06 to c1dfdab Compare May 22, 2025 10:02
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from d81b38e to 57d2097 Compare May 22, 2025 10:02
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_liveness_check_stage_to_system_test_workflow branch from c1dfdab to b20b9d1 Compare May 22, 2025 10:11
@nadin-Starkware nadin-Starkware force-pushed the 05-21-feat_deployment_add_sequencer_readiness_check_stage_to_system_test_workflow branch from 57d2097 to daefad8 Compare May 22, 2025 10:11
This was referenced May 22, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware Itay-Tsabary-Starkware requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadin-Starkware @reviewable-StarkWare @Itay-Tsabary-Starkware