Skip to content

refactor(blockifier): return an enum in commit_tx #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

refactor(blockifier): return an enum in commit_tx #6653

merged 1 commit into from
May 22, 2025

Conversation

liorgold2
Copy link
Contributor

@liorgold2 liorgold2 commented May 21, 2025 •
edited
Loading

@liorgold2 liorgold2 mentioned this pull request May 21, 2025
Merged
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

Artifacts upload workflows:

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/blockifier4/6c28d8d8 branch from c1bfc89 to 453c904 Compare May 22, 2025 08:25
avi-starkware
avi-starkware approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/blockifier4/6c28d8d8 branch from 453c904 to e758ef6 Compare May 22, 2025 08:37
avi-starkware
avi-starkware approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/blockifier4/6c28d8d8 branch from e758ef6 to d39870c Compare May 22, 2025 10:27
@liorgold2 liorgold2 mentioned this pull request May 22, 2025
Merged
avi-starkware
avi-starkware approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/blockifier4/6c28d8d8 branch 2 times, most recently from f560692 to 40aa393 Compare May 22, 2025 11:53
This was referenced May 22, 2025
Merged
Merged
Yoni-Starkware
Yoni-Starkware approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/blockifier4/6c28d8d8 branch from 40aa393 to 7d94700 Compare May 22, 2025 12:39
@liorgold2 liorgold2 enabled auto-merge May 22, 2025 12:40
liorgold2
liorgold2 commented May 22, 2025
View reviewed changes
Copy link
Contributor Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 added this pull request to the merge queue May 22, 2025
Merged via the queue into main-v0.14.0 with commit 5fa2d15 May 22, 2025
15 of 40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@avi-starkware avi-starkware avi-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liorgold2 @reviewable-StarkWare @Yoni-Starkware @avi-starkware