Enhance blacklist handling: regex replacements and partial date removal #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithoutPants
requested changes
Apr 2, 2025
Comment on lines
+131
to
+148
| const regexReplacements = new Map<string, string>(); | ||
| const regexs = blacklist | ||
| .map((entry) => { | ||
| let [pattern, replacement] = entry.split("||"); // Extract regex and replacement | ||
|
|
||
| try { | ||
| const compiledRegex = new RegExp(pattern, "gi"); | ||
|
|
||
| if (replacement !== undefined ){ | ||
| regexReplacements.set(compiledRegex.source, replacement); // Store replacement | ||
| } | ||
|
|
||
| return compiledRegex; | ||
| } catch { | ||
| return null; // Ignore invalid regex patterns | ||
| } | ||
| }) | ||
| .filter((r) => r !== null) as RegExp[]; |
There was a problem hiding this comment.
It's not ideal to use map and then mutate stuff outside it. Instead, I would return a tuple (return [compiledRegex, replacement]). Then, these pairs of values can be handled in the code below. I would also move this into a separate function.
Comment on lines
+151
to
+159
| regexs.forEach((regex) => { | ||
| const replacement = regexReplacements.get(regex.source); | ||
| if (replacement) { | ||
| str = str.replace(regex, (match:string, ...groups: string[]) => { | ||
| return replacement.replace(/\\(\d+)/g, (_, groupIndex) => groups[parseInt(groupIndex, 10) - 1] || ""); | ||
| }); | ||
| } else { | ||
| str = str.replace(regex, ""); | ||
| } |
There was a problem hiding this comment.
This should also be moved into a separate function. The code between 154-156 needs some explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is still a draft as I am TERRIBLE with Regex and just as bad with coding. Please let me know if there is anything that needs fixed, I'm happy to do so.
||delimiter to allow custom replacements (e.g., "bwb||bigwetbutts")-DD) fromYYYY-MM-DDwhile keepingYYYY-MM"(\d{4}-\d{2})-\d{2}||$1"removes-DDbut preservesYYYY-MMtry/catch