Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix bug {{ collection:previous|next }} in collection with date and time enabled #11670

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from

Conversation

liucf
Copy link

@liucf liucf commented Apr 7, 2025

fixed #11263

@liucf liucf closed this Apr 7, 2025
@liucf liucf force-pushed the fix/issue-11663 branch from 94c3d16 to bb58cfd Compare April 7, 2025 08:40
@liucf liucf reopened this Apr 7, 2025
@duncanmcclean
Copy link
Member

Would you be able to add a test for this fix? We have tests for the collection:previous/next tags in CollectionTest.

@liucf
Copy link
Author

liucf commented Apr 7, 2025

@duncanmcclean Added test. This bug only occurs when using 'driver' => 'file'. The test suite runs with SQLite, which uses the 'eloquent' driver, so it doesn't catch this bug.

However, when testing it manually through the browser with the 'file' driver, this PR does fix the issue.

@duncanmcclean
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buggy {{ collection:previous|next }} in collection with date and time enabled
2 participants