[5.x] Static Cache Middleware - skip cache if new header is set #11817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not have a way to determine ourselves if something should be skipped or not.
One option would have been to add
X-Statamic-Draftto the headers, but this seemed "dirty". A new header allows us to skip the cache conditionally:X-Statamic-No-Static-Cacheand would work well for others as well - it's clear, to-the-point, and distinct.Our use case: we do NOT want to cache 404 responses in some instances - so we want to add that header where applicable.
Considered also
X-Statamic-Skip-Static-Cache, but opted for shorter version with "No" instead of "Skip". Also consideredX-Statamic-No-Cache, but thought that might be confused with Nocache (a separate implementation).