feat: new Shell (jump to) home screen #17916
Open
+2,899
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
feat/shell-mode-home
branch
from
797014f to
e7070cb
Compare
Jenkins BuildsClick to see older builds (219)
|
caybro
force-pushed
the
feat/shell-mode-home
branch
21 times, most recently
from
4c87e1b to
46f8a04
Compare
caybro
force-pushed
the
feat/shell-mode-home
branch
6 times, most recently
from
7338be6 to
db5dd41
Compare
caybro
force-pushed
the
feat/shell-mode-home
branch
from
e6029b7 to
15a5e21
Compare
- Shell becomes the new startup/home screen; hidden behind a feature flag - has a searchable grid, providing an overview of chats, communities, wallets, settings etc - some related smaller component and storybook page fixes - cleanup some clazy warnings Fixes #17971
caybro
force-pushed
the
feat/shell-mode-home
branch
from
15a5e21 to
52b9734
Compare
- consistently for all notification badges/counters, instead of deriving it from the item's (community, chat, ...) color
- everytime a user activates/interacts with some element, we update the item's timestamp, and use that for sorting - plus the according persistance fixes
jrainville
reviewed
May 28, 2025
There was a problem hiding this comment.
That's awesome! Very good work.
I added a lot of comments, but a lot of them are repeated or just asking for info.
Question: is the shell keyboard navigable? If not, we should add that as an issue. Having it on ctrl+J then navigating with the keyboard sounds very cool and useful
| anchors.fill: parent | ||
|
|
||
| Component.onCompleted: { | ||
| if (appMain.featureFlagsStore.shellEnabled) | ||
| appMain.rootStore.mainModuleInst.setActiveSectionBySectionType(Constants.appSection.chat) // force the chat section to finish loading |
There was a problem hiding this comment.
I think this code should be in the main module. In load and/or in onChatsLoaded. That's where the current code for setting the current active section is.
There was a problem hiding this comment.
However, is there a way to close the Shell to actually go back to the last section opened? I'm not sure if that's a real user flow, but as the app is right now, it's kinda cool that it reopens the last chat for example. So as a chat app it's nice.
Though as an OS, it makes sense to show the "desktop" or shell in this case when reopening.
Anyway, just brainstorming here.
| readonly property bool sectionsLoaded: appMain.rootStore.mainModuleInst && appMain.rootStore.mainModuleInst.sectionsLoaded | ||
|
|
||
| sectionsBaseModel: sectionsLoaded ? appMain.rootStore.mainModuleInst.sectionsModel : null | ||
| chatsBaseModel: sectionsLoaded ? appMain.rootStore.mainModuleInst.getChatSectionModule().model // FIXME model null initially or with empty images |
There was a problem hiding this comment.
Yeah I think there's some missing "dataChanged" signal somewhere in NIM code; will open a separate issue
There was a problem hiding this comment.
You can see it here:
Topleft (grid) item doesn't have the icon; bottom right in the dock (pinned) does, as the latter is done async and later (probably the model is properly initialized at that point already)
Once I activate that chat, everything's fine
Nope :( But again this is a generic problem; we are missing keyboard focus states for all the buttons and grid items and whatnot CC @benjthayer |
…onent - shared between AppMain and the ShellContainer
- so that it can be reused between settings and the shell
- when the url starts with `qrc:/`, do not consider that as a remote file
|
@jrainville addressed your comments/feedback (in separate followup commits); pls have a second look. I can raise separate issues for the missing/faulty chat section behavior |
|
I just realized, in your video, the chat icons are square for the ones without images: |
Yeah I fixed that already in the meantime, just forgot to update the video |
jrainville
approved these changes
May 30, 2025
This was referenced Jun 2, 2025
This was
unlinked from
issues
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
(additional fixes in separate commits)
Fixes #18032
Part of #17971
Affected areas
AppMain, Shell
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2025-05-23.12-46-30.mp4