Skip to content

feat: Make onboarding and login possible on portrait mode #18014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: feat/basic-portrait-layout
Choose a base branch
from
Draft

feat: Make onboarding and login possible on portrait mode #18014

wants to merge 4 commits into from
+247 −48

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented May 29, 2025 •
edited
Loading

WIP

What does the PR do

Updating the login screen and the welcome view so that we can use it on phones.

Changes:

  • WelcomeView implements a GridView that will change the column and row layout based on view width and height. The UI on portrait mode is preserved
  • LoginView - Changes the anchors so that the elements are centered in the view. It's a different layout since the previous layout was fixed 200px from the top of the screen. cc @benjthayer
  • Fixing the wallet footer. Adding a 600px breakpoint where the footer won't display the button text

Affected areas

Login view
Welcome view

Architecture compliance

Screenshot of functionality (including design for comparison)

Screen.Recording.2025-05-29.at.14.25.59.mov
Screen.Recording.2025-05-29.at.14.27.30.mov

@alexjba alexjba requested a review from benjthayer May 29, 2025 11:36
@status-im-auto
Copy link
Member

status-im-auto commented May 29, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (14)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 7ba402e #1 2025-05-29 11:46:15 ~9 min tests/ui 📄log
✔️ 7ba402e #1 2025-05-29 11:46:20 ~9 min tests/nim 📄log
✔️ 7ba402e #1 2025-05-29 11:47:02 ~10 min macos/aarch64 🍎dmg
✔️ 7ba402e #1 2025-05-29 11:57:13 ~20 min macos/x86_64 🍎dmg
✔️ 7ba402e #1 2025-05-29 11:58:06 ~21 min linux-nix/x86_64 📦tgz
✔️ 7ba402e #1 2025-05-29 12:03:29 ~26 min windows/x86_64 💿exe
✔️ 7ba402e #1 2025-05-29 12:03:36 ~26 min linux/x86_64 📦tgz
✔️ f900c9c #2 2025-05-29 12:36:35 ~6 min macos/aarch64 🍎dmg
✔️ f900c9c #2 2025-05-29 12:38:33 ~8 min tests/nim 📄log
❌ f900c9c #2 2025-05-29 12:39:39 ~10 min tests/ui 📄log
✔️ f900c9c #2 2025-05-29 12:43:35 ~13 min macos/x86_64 🍎dmg
✔️ f900c9c #2 2025-05-29 12:51:20 ~21 min windows/x86_64 💿exe
✔️ f900c9c #2 2025-05-29 12:53:09 ~23 min linux/x86_64 📦tgz
✔️ f900c9c #2 2025-05-29 12:55:03 ~25 min linux-nix/x86_64 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4d87453 #3 2025-05-30 08:54:05 ~6 min tests/nim 📄log
❌ 4d87453 #3 2025-05-30 08:54:44 ~7 min tests/ui 📄log
✔️ 4d87453 #3 2025-05-30 08:55:22 ~7 min macos/aarch64 🍎dmg
✔️ 4d87453 #3 2025-05-30 09:01:19 ~13 min linux-nix/x86_64 📦tgz
✔️ 4d87453 #3 2025-05-30 09:01:46 ~14 min linux/x86_64 📦tgz
✔️ 4d87453 #3 2025-05-30 09:03:11 ~15 min macos/x86_64 🍎dmg
✔️ 327554b #4 2025-05-30 09:19:29 ~6 min tests/nim 📄log
✔️ 327554b #4 2025-05-30 09:20:21 ~6 min macos/aarch64 🍎dmg
❌ 327554b #4 2025-05-30 09:21:03 ~7 min tests/ui 📄log
✔️ 327554b #4 2025-05-30 09:24:07 ~10 min linux-nix/x86_64 📦tgz
✔️ 327554b #4 2025-05-30 09:27:31 ~14 min macos/x86_64 🍎dmg
✔️ 327554b #4 2025-05-30 09:27:46 ~14 min linux/x86_64 📦tgz
✔️ 327554b #4 2025-05-30 09:34:18 ~20 min windows/x86_64 💿exe

@alexjba alexjba requested a review from a team as a code owner May 29, 2025 12:29
@alexjba alexjba requested review from dlipicar and Cuteivist and removed request for a team May 29, 2025 12:29
caybro
caybro reviewed May 29, 2025
View reviewed changes
storybook/pages/StatusSectionLayoutPage.qml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should go to the parent PR?

ui/StatusQ/src/StatusQ/Layout/StatusSectionLayoutLandscape.qml
@@ -211,12 +211,12 @@ SplitView {
anchors.bottomMargin: footerSlot.visible ? 8 : 0
target: root.centerPanel
}
Item {
LayoutItemProxy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this type coming from? :)

ui/StatusQ/src/StatusQ/Layout/StatusSectionLayoutLandscape.qml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, parent PR?

ui/StatusQ/src/StatusQ/Layout/StatusSectionLayoutPortrait.qml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@alexjba alexjba marked this pull request as draft May 30, 2025 06:23
@alexjba alexjba force-pushed the feat/basic-portrait-layout branch from 8d6b4e9 to ebbaec6 Compare May 30, 2025 06:52
@alexjba alexjba force-pushed the feat/basic-portrait-layout-onboarding branch from f900c9c to 4d87453 Compare May 30, 2025 08:47
@anastasiyaig
Copy link
Contributor

desktop app is crashing in this PR . I see the PR is still in draft, so just saying

WRN 2025-05-30 09:28:49.546Z qt warning                                 topics="qt" tid=2390949 text="Dialog is not a type" file=qrc:/StatusQ/Popups/Dialog/StatusDialog.qml:12 category=default
INF 2025-05-30 09:28:49.546Z starting application...                    topics="status-app" tid=2390949 file=nim_status_client.nim:261
DBG 2025-05-30 09:28:49.550Z keycard started                            topics="keycardV2-service" tid=2390949 file=service.nim:132
WRN 2025-05-30 09:28:49.550Z Error decoding signal                      topics="signals-manager" tid=2390949 file=signals_manager.nim:49 err="Unknown signal received: mediaserver.started"
WRN 2025-05-30 09:28:49.550Z qt warning                                 topics="qt" tid=2390949 text="Error while loading QML: QUrl(\"qrc:/main.qml\")" file=:0 category=default
INF 2025-05-30 09:28:49.550Z shutting down...                           topics="status-app" tid=2390949 file=nim_status_client.nim:226
INF 2025-05-30 09:28:49.554Z logging out...                             topics="app-controller" tid=2390949 file=app_controller.nim:291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro left review comments

@benjthayer benjthayer Awaiting requested review from benjthayer

@micieslak micieslak Awaiting requested review from micieslak micieslak is a code owner

@noeliaSD noeliaSD Awaiting requested review from noeliaSD noeliaSD is a code owner

@dlipicar dlipicar Awaiting requested review from dlipicar dlipicar is a code owner automatically assigned from status-im/desktop-wallet

@Cuteivist Cuteivist Awaiting requested review from Cuteivist Cuteivist is a code owner automatically assigned from status-im/desktop-wallet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexjba @status-im-auto @anastasiyaig @caybro