fix(collectibles): fix sending of collectibles in the SimpleSendModal #18023
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
Khushboo-dev-cpp and
saledjenic
and removed request for
a team
Jenkins Builds
|
saledjenic
reviewed
Jun 2, 2025
| @@ -327,7 +327,7 @@ StatusDialog { | |||
| selectedCollectibleEntry.item.symbol: "" | |||
|
|
|||
| readonly property double maxSafeCryptoValue: { | |||
| root.assetsModel.ModelCount.count | |||
| !!d.selectedAssetEntry.item.balances ? d.selectedAssetEntry.item.balances.ModelCount.count : null | |||
There was a problem hiding this comment.
Since this is here just to trigger the binding, then I guess just d.selectedAssetEntry.item.balances should be enough?
saledjenic
approved these changes
Jun 2, 2025
Khushboo-dev-cpp
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18015 and #18018
Cherry-pick of #18020
NOTE: there was a conflict in this cherry-pick. Please double check @Khushboo-dev-cpp to see if the property used now is good