[Draft] Experimental fork: replace native usage of BigInt with JSBI.
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that React Native does not have strong support for
BigIntliterals (see facebook/react-native#34603 (comment)), this library (and, by extension, the entire Stellar JavaScript SDK, e.g.stellar-baseandstellar-sdk) is not compatible with React Native.The ecosystem recommendation is to use
JSBIas a drop-in replacement forBigInt, then use a Babel plugin (transform-jsbi-to-bigint) to transpile the final code to have nativeBigInts.This is an experimental fork to port the codebase to use JSBI.
As far as I understand, we should not use the aforementioned plugin in this codebase and rather let downstream systems with strong
BigIntsupport do the replacement. Unfortunately, this would have to be an "opt-in" action rather than an "opt-out", so the best path forward to getting this into RN projects is still unclear.