Skip to content

fix(ci): hardening security of GH actions #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

Currently, our GitHub Actions workflows have several security vulnerabilities:

  • They use floating versions for actions, which can lead to supply chain attacks if a dependency is compromised.
  • They lack explicit permission blocks, granting them more access than necessary.
  • Some tests are running on outdated Node.js versions.
  • The dev server is vulnerable to directory traversal attacks.

GitHub Issue Number: N/A

What is the new behavior?

This pull request hardens the security of our GitHub Actions and the dev server by:

  • Pinning all actions to a specific commit SHA to ensure we are using a specific, audited version.
  • Adding permissions blocks to all workflows to enforce the principle of least privilege, mostly restricting them to contents: read.
  • Removing Node.js v16 from the test matrix for several test jobs.
  • Fixing a bug in test-types.yml where a matrix was missing.
  • Adding a check in the dev server to prevent directory traversal.
  • Removing the deprecated renovate.json5 configuration.

Documentation

N/A

Does this introduce a breaking change?

  • Yes
  • No

Testing

All changes were applied directly to the CI configuration. The CI pipeline itself will validate the changes.

Other information

N/A

@christian-bromann christian-bromann requested a review from a team as a code owner June 17, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant