Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add CustomStringConvertible for Setter #1279

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

dyikai
Copy link
Contributor

@dyikai dyikai commented Sep 26, 2024

Setter has a extension of Expressible, but the asSQL() is internal, so I implement the CustomStringConvertible like the Expressions.

Thanks for taking the time to submit a pull request.

Before submitting, please do the following:

  • Run make lint to check if there are any format errors (install swiftlint first)
  • Run swift test to see if the tests pass.
  • Write new tests for new functionality.
  • Update documentation comments where applicable.

@nathanfallet nathanfallet merged commit c7b78f2 into stephencelis:master Dec 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants