Remove linking unless explicitly enabling testing #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@d-unseductable / @malept : So, here's my solution to the discussion in #25.
Basically the idea is to only pass the linkage to
libruby
when we buildruby-sys
with--features=test
. It's kind of ghetto that you have to actually feature-flag it, but it looks like that's the only way of really doing that in a build script as far as I can tell. Also, since you literally only need to linklibruby
when you would want to run Rust tests, I figure there's no real difference in just supporting dynamic linking.I'll also submit a PR for
ruru
to re-export the feature flag so that the Rust tests can still be run.