Skip to content

refactored large test for strict mode #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Conversation

marilynel
Copy link
Contributor

@marilynel marilynel commented Apr 13, 2025

Fixes #952

@stleary
Copy link
Owner

stleary commented Apr 13, 2025

What problem does this code solve?
A few dozen unit tests were skipped during strict mode, but only 2 were actually failing. This commit refactors the unit tests into separate methods.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, unit tests were refactored

Was any code refactored in this commit?
Yes

Review status
APPROVED

Starting 3-day comment window

NOTE 2 tests had the exception message assert commented out, since the purpose was to confirm the exception, not the message. However, this is still tech debt that can be fixed in a later commit.

@stleary stleary merged commit 82a02d8 into stleary:master Apr 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor JSONObjectTest jsonObjectParsingErrors()
2 participants