Impl Read<u8> / Write<u8> for Serial

[dbrgn]

Fixes #167.

I managed to implement this without having split tx/rx pins in the Serial struct thanks to the help of @Disasm. Instead, it uses a private trait (UsartReadWrite) to avoid having duplicated peripheral access logic. There should be no breaking change in this PR.

[TheZoq2]

Seems like a nice and simple change, good job! The last matrix message seems to suggest that you may want to make additional improvements. Is that the case or is it ready for merging?

[dbrgn]

The last matrix message seems to suggest that you may want to make additional improvements. Is that the case or is it ready for merging?

I couldn't figure out how to implement the change suggested by @Disasm, but maybe I misunderstood something...

To me, it seems better to keep the trait methods as associated functions without a &self reference, since they actually are static and don't require a reference to an instance.

[Disasm]

Passing &self ensures ownership, but it is something we do not have in all of the cases anyway. I'm trying to improve this code locally it's dfficult to implement this way. So LGTM. Maybe I will improve this in the future.

[Disasm]

Well, I have an update. Should I open a PR to the dbrgn's PR or should I PR my changes here after this PR gets merged?

[dbrgn]

Well, I have an update. Should I open a PR to the dbrgn's PR or should I PR my changes here after this PR gets merged?

If you want, you can also send me the patch (git show > patch.txt) and I'll add it to this PR 🙂

[Disasm]

Here we are: dbrgn#1

[dbrgn]

Thanks! I merged your changes, will add a comment.

[Disasm]

With this implementation only one copy of UsartReadWrite::{read/write/flush} is created in debug, as opposed to the original implementation with macros.

[dbrgn]

I rebased the branch and squashed my fixup commits. I also integrated the "Strip confusing comment" commit into the commit "Deduplicate USART driver code".

From my side, this PR is now ready.

[Disasm]

@TheZoq2 could you review this one more time?

[TheZoq2]

Looks great, thank you both for your work!

[TheZoq2]

Oh yea, just one minor thing. Would you mind adding a changelog entry before I merge?

[dbrgn]

Oh yea, just one minor thing. Would you mind adding a changelog entry before I merge?

Sure! Forgot about that. Done!

[TheZoq2]

Lovely!